ci+docs: match style with epipredict #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshemetov
requested review from
brookslogan,
dsweber2 and
nmdefries
as code owners
brookslogan
reviewed
Feb 16, 2024
| bg: '#C41230' | ||
| fg: '#f8f8f8' | ||
| bg: primary | ||
| type: dark |
There was a problem hiding this comment.
doesn't seem to match epiprocess here. Are they actually the same or do we need to update one of them?
There was a problem hiding this comment.
I think we need to update epiprocess because its docs don't have the right colors either (though they don't have the strange invisibility problem).
4 tasks
nmdefries
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Header bar text is unreadable on epidatr/dev docs, fix by matching the settings in
_pkgdown.ymlwith the settings in epipredict , which look correct. I tested this locally with:build_home_index(); init_site()and thenpython -m http.serverto host.Also matches the pkgdown ci with how it's done in epiprocess (based on branch instead of .9000 version numbers).