Skip to content

Extending tests #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jun 9, 2023
Merged

Extending tests #118

merged 18 commits into from
Jun 9, 2023

Conversation

dsweber2
Copy link
Contributor

@dsweber2 dsweber2 commented Jun 1, 2023 •
edited
Loading

closes #93, closes #64 (eventually) Still working through the list in #93, will check those off when they're present here. This may include bugfixes identified in writing tests.

dsweber2 added 16 commits May 31, 2023 11:05
@dsweber2
tests: mockery version for first 4 epidatacall
9af93f4 
adding coverage for lines 124, 152, 219 and 324 of epidatacall.R
@dsweber2
switching to strictly testthat mocking
e8cec4f
@dsweber2
tests & fix: edge case in covidcast_epidata
fdf1ae0
@dsweber2
test: do_request doesn't have a block tested
93d23ba
@dsweber2
test & fix: name completion is unique
b9afa52
@dsweber2
typo: accidentally changed title during rebase
a98ecaa
@dsweber2
typos: res -> response, don't do external calls
484fb05 
with_mocked is borked, use local_mocked instead
@dsweber2
test: fields non-NULL, remove unused test
c0f6d2e
@dsweber2
refactor: delete completely unused internal function
77c567a
@dsweber2
test: various parsing
5408b9f
@dsweber2
ci/docs: codecov badge
c8bf8da
@dsweber2
ci: correct secret location
6bb12cc
@dsweber2
ci: manual triggers
2bfbd09
@dsweber2
CI: tmp needed to debug on remote
d30937d
@dsweber2
ci: actual codecov link (dsweber2/extendingTests)
c487250
@dsweber2
ci: codecov pointing at dev
5aab85f
@dsweber2
Copy link
Contributor Author

dsweber2 commented Jun 2, 2023

The last 6 ci commits are the tools for codecov, which are working on my branch specifically; as I see it, there are 3 options:

  1. not bother with codecov
  2. use my personal codecov account, so I'll have to keep my fork up to date religiously
  3. someone with admin access on the repo add a delphi codecov secret key and correct the link in the README.md

@dsweber2 dsweber2 marked this pull request as ready for review June 2, 2023 22:26
dshemetov
dshemetov approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@dshemetov dshemetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as is.

I skimmed the tests and they looked good to me.

I looked at the coverage report and it was 95%, the remaining lines being print formatting lines that we don't need to unit test.

dsweber2 and others added 2 commits June 9, 2023 13:08
@dsweber2 @dshemetov
any pull request
b717ed1 
Co-authored-by: Dmitry Shemetov <[email protected]>
@dsweber2 @dshemetov
CI: we care most about the dev branch
403f1a0 
Co-authored-by: Dmitry Shemetov <[email protected]>
@dsweber2 dsweber2 merged commit 9282f34 into cmu-delphi:dev Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshemetov dshemetov dshemetov approved these changes

@brookslogan brookslogan Awaiting requested review from brookslogan brookslogan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve test coverage Don't duplicate source name in names(covidcast_epidata()$signals)
2 participants
@dsweber2 @dshemetov