first pass endpoints vignette (for closing #96) (take 2) #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namely, several endpoints are returning errors, and there are some with uncertain sourcing. documented inline with TODOs
I hadn't compiled the html link that was broken into the actual man
pages.
I added links to `covidcast_epidata` to `covidcast_meta` and
`covidcast`, and an example of the use of * to covidcast.
When I compiled the roxygen2 docs, an extra \details{ appeared, which I
assume is because of a change someone else made that didn't get compiled in.
the delphi endpoint's fetch_classic output has been modified to just names, since the full output is too long Secrets moved to the .Reviron file. Duplicate copy of Google Health Trends removed various references fixed
dshemetov
requested changes
May 26, 2023
|
and done |
|
Closes #96. |
`fetch()` now raises epidata errors and warnings and returns `$epidata`, rather than the result-message-epidata triplet; update vignette to remove `$epidata`. Also, index to get the first and only forecast returned.
brookslogan
approved these changes
May 26, 2023
There was a problem hiding this comment.
Changes were already approved in #102 + a few typos and a compatibility update have been addressed.
dshemetov
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #102 for actual discussion, this should be ready to merge as is.