Skip to content

covid_hosp_facility_lookup should warn/error for not implemented cases #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dsweber2 opened this issue May 5, 2023 · 1 comment · Fixed by #146
Closed

covid_hosp_facility_lookup should warn/error for not implemented cases #98

dsweber2 opened this issue May 5, 2023 · 1 comment · Fixed by #146
Labels
invalid This doesn't seem right P1 medium priority

Comments

@dsweber2
Copy link
Contributor

dsweber2 commented May 5, 2023

Unsure if this exists as an issue already, but the call

covid_hosp_facility_lookup(state = "WY", city = "New York") %>% fetch_tbl()

silently just returns the state result. As more than one input is invalid, this should probably return an error/warning to that effect.
@dsweber2 dsweber2 added invalid This doesn't seem right triage Should assign/revisit priority level, other tags labels May 5, 2023
@dshemetov
Copy link
Contributor

dshemetov commented May 6, 2023 •
edited
Loading

Related to the discussion here. If we commit to doing those checks in the server, then no need to do that here.

@dshemetov dshemetov added P1 medium priority and removed triage Should assign/revisit priority level, other tags labels Jul 18, 2023
@dshemetov dshemetov mentioned this issue Aug 12, 2023
Closed
37 tasks
dshemetov added a commit that referenced this issue Aug 12, 2023
@dshemetov
fix: mutually exclusive args #98
e4b1ee0
@dshemetov dshemetov mentioned this issue Aug 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right P1 medium priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: covidcast_epidata cmu-delphi/epidatr
2 participants
@dshemetov @dsweber2