Skip to content

Use consistent naming for covidcast data_sources/sources #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brookslogan opened this issue Oct 4, 2022 · 1 comment · Fixed by #146
Closed

Use consistent naming for covidcast data_sources/sources #53

brookslogan opened this issue Oct 4, 2022 · 1 comment · Fixed by #146
Assignees
Labels
P1 medium priority

Comments

@brookslogan
Copy link
Contributor

Use the same base name for data-source-associated:

  • parameters to covidcast and related functions
  • elements of covidcast_epidata()
  • columns of covidcast results
  • etc.

Either source and sources or data_source and data_sources.

@brookslogan brookslogan added the P1 medium priority label Oct 4, 2022
@dsweber2 dsweber2 self-assigned this May 17, 2023
@dshemetov dshemetov mentioned this issue Jul 26, 2023
37 tasks
@dshemetov
Copy link
Contributor

So this is tricky because:

  • source overwrites a keyword in R
  • sources is misleading in covidcast, because it only accepts one source
  • data_source(s) are both long for covidcast_epidata (which aims to be a handy autocomplete thing)

I'm going with (1), even though it feels slightly wrong: I really don't expect anyone to need the source keyword inside the covidcast function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 medium priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants