Skip to content

TEST - Build and image with new Flask and SQLAlchemy #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 9, 2022
Merged

TEST - Build and image with new Flask and SQLAlchemy #973

merged 7 commits into from
Sep 9, 2022

Conversation

korlaxxalrok
Copy link
Contributor

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

korlaxxalrok and others added 5 commits September 6, 2022 16:42
@korlaxxalrok
Build an image from this branch
3994eef
@korlaxxalrok
Update to latest Flask and SQLAlchemy
443c44b
@korlaxxalrok
Update werkzeug
831e4b6
@korlaxxalrok
Use Row instead of RowProxy
6c72760
@melange396
fixes build for bumped versions of flask & etc.
3d55cfa 
updated Dockerfile to let pip account for all version constraints simultaneously (previous non-simultaneous (ie, sequential) requirements installation resulted in a version conflict on `greenlets` package, see: tiangolo/meinheld-gunicorn-docker#22 ).
also bumped python version in that Dockerfile to 3.8 to match python versions elsewhere in the codebase.
*note: this fix also requires a change to version pinning in a requirements.txt of the operations branch (see: https://github.com/cmu-delphi/operations/blob/v4-schema-revisions-release-prep-flaskalchemy/dev/docker/python/assets/requirements.txt )
@krivard krivard requested a review from nolangormley September 9, 2022 14:08
@krivard krivard marked this pull request as draft September 9, 2022 14:14
@melange396
make some sqlalchemy config options explicit (and not dependent on ex…
f06a7f0 
…ternal specification) because they fundamentally change behaviors
@melange396
remove reference to this branch from ci.yaml, in anticipation of merg…
fd7b815 
…e and deletion of this branch
@melange396
Copy link
Collaborator

i have a commit staged and ready to push that reverts the self-referential mention of this branch in ci.yaml. i will push that right before merge.

@melange396 melange396 marked this pull request as ready for review September 9, 2022 15:05
nolangormley
nolangormley approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@nolangormley nolangormley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good. Checked with George on the double requirements file, but it's documented well so I think it's good. All tests passed on my system as well.

@melange396
Copy link
Collaborator

ty! pushing other change and then merging now

@melange396 melange396 merged commit bbd596b into v4-schema-revisions-release-prep Sep 9, 2022
@melange396 melange396 deleted the v4-schema-revisions-release-prep-flaskalchemy branch September 9, 2022 16:28
@melange396 melange396 mentioned this pull request Sep 9, 2022
Merged
@melange396 melange396 restored the v4-schema-revisions-release-prep-flaskalchemy branch September 12, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolangormley nolangormley nolangormley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@korlaxxalrok @melange396 @nolangormley