#798 fix bad table #952
Merged
#798 fix bad table #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. combine the signal and 7-day signal columns to one column 3. remove the geography and resolution columns and add universal explain below the table to make the description column text more visible
krivard
suggested changes
Aug 24, 2022
There was a problem hiding this comment.
Preview:
Please change the description text back to left alignment; center alignment is mismatched with the other pages and is difficult to read.
The raw counts and 7dav signals needn't be separated by newlines, and we should switch from ampersands to and; see the CTIS page for an example.
2. change & to and, also adjust the lines
|
Sure, the changes are made and up-to-date. Is there any other issues related to the table? |
|
Great! Apply same fix to JHU and USAFacts. |
2. combine the Signal column with 7-day average signal column
|
For the table issue, JHU and USAFacts pages are all fixed. |
krivard
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #798