Skip to content

Deactivate SafeGraph Weekly Patterns signals. #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 30, 2022
Merged

Deactivate SafeGraph Weekly Patterns signals. #932

merged 2 commits into from
Aug 30, 2022

Conversation

krivard
Copy link
Contributor

@krivard krivard commented Jun 16, 2022 •
edited
Loading

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

  • List SafeGraph Weekly Patterns indicator documentation on the inactive indicators page for SafeGraph.
  • Remove active indicators page for SafeGraph.

@krivard
Deactivate SafeGraph Weekly Patterns signals.
90798f9 
List SafeGraph Weekly Patterns indicator documentation on the inactive page.
Remove active SafeGraph page.
@krivard krivard force-pushed the krivard/deactivate-safegraph branch from e6688e1 to 90798f9 Compare August 29, 2022 17:53
@krivard krivard requested a review from dshemetov August 29, 2022 17:54
dshemetov
dshemetov previously approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@dshemetov dshemetov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm going to push a few more commits with present -> past tense conversions for SafeGraph descriptions and make the not updated text in bold, but that's it.

@dshemetov dshemetov self-requested a review August 29, 2022 23:38
@krivard krivard merged commit d3eb8d5 into dev Aug 30, 2022
@krivard krivard deleted the krivard/deactivate-safegraph branch August 30, 2022 16:57
@krivard krivard mentioned this pull request Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshemetov dshemetov dshemetov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krivard @dshemetov