Skip to content

[CTIS] Add note that current SEs are unweighted #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 31, 2022

Conversation

nmdefries
Copy link
Contributor

Summary

  • Add banner with note that current SEs are unweighted.
  • Change weighted indicators link in contingency tables page to properly point to weighting discussion.

@nmdefries nmdefries requested a review from capnrefsmmat May 27, 2022 18:47
Copy link
Contributor

@capnrefsmmat capnrefsmmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, we haven't used \( as a math delimiter in this file before, but KaTeX appears to support it, so I guess we can. (And probably should, since apparently it's for inline math and $$ is for display math)

@nmdefries
Copy link
Contributor Author

I was struggling a lot with getting $$ to display as in-line rather than as a block. Something about being inside of a div?

@capnrefsmmat
Copy link
Contributor

My read of the KaTeX manual is that it treats $$ to mean display (block) math by default. Somehow that works fine in most of the docs. In any case I rendered the documentation with Jekyll and your update looks fine, so I'm fine leaving it as you wrote it.

@krivard krivard merged commit 9abe0ef into dev May 31, 2022
@krivard krivard deleted the ndefries/alert-unweighted-ses branch May 31, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants