Skip to content

Added vaccination signals to the documentation #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Feb 24, 2022
Merged

Added vaccination signals to the documentation #851

merged 16 commits into from
Feb 24, 2022

Conversation

Ananya-Joshi
Copy link
Contributor

No description provided.

@Ananya-Joshi
Copy link
Contributor Author

Not sure what to do about the testing errors - any guidance would be appreciated!

@nmdefries
Copy link
Contributor

Test failure is related to a new version of itsdangerous. Some discussion and fixes here and here.

@nmdefries nmdefries mentioned this pull request Feb 21, 2022
Merged
@krivard
Copy link
Contributor

krivard commented Feb 21, 2022

that was fixed in #849 -- if you merge dev back into this branch that should do it

krivard
krivard suggested changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits, some light restructuring, rewrote the High-Visibility Data Notes limitation for audience. Double check my larger edits for accuracy please 🙏

@krivard
Copy link
Contributor

krivard commented Feb 22, 2022

would you add a line to Lag and Backfill for vaccination signals?

Ananya-Joshi and others added 10 commits February 22, 2022 14:00
@Ananya-Joshi @krivard
Update docs/api/covidcast-signals/dsew-cpr.md
b71c56c 
Co-authored-by: Katie Mazaitis <[email protected]>
@Ananya-Joshi @krivard
Update docs/api/covidcast-signals/dsew-cpr.md
ed30d1b 
Co-authored-by: Katie Mazaitis <[email protected]>
@Ananya-Joshi @krivard
Update docs/api/covidcast-signals/dsew-cpr.md
6343281 
Co-authored-by: Katie Mazaitis <[email protected]>
@Ananya-Joshi @krivard
Update docs/api/covidcast-signals/dsew-cpr.md
7200bc7 
Co-authored-by: Katie Mazaitis <[email protected]>
@Ananya-Joshi @krivard
Update docs/api/covidcast-signals/dsew-cpr.md
62ee3ab 
Co-authored-by: Katie Mazaitis <[email protected]>
@Ananya-Joshi @krivard
Update docs/api/covidcast-signals/dsew-cpr.md
1d0704d 
Co-authored-by: Katie Mazaitis <[email protected]>
@Ananya-Joshi
added lag and backfill for vacc data
78af864
@Ananya-Joshi @krivard
Update docs/api/covidcast-signals/dsew-cpr.md
fb2abf6 
Co-authored-by: Katie Mazaitis <[email protected]>
@Ananya-Joshi
Lag Date Changes
a316e0a
@krivard
CPR limitations: high-visibility data notes
2855731
krivard
krivard suggested changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lag section is for COVIDcast lag, not CPR file lag; limitations section context is CPR file lag

@Ananya-Joshi
Copy link
Contributor Author

Lag section is for COVIDcast lag, not CPR file lag; limitations section context is CPR file lag

Thank you for catching that!

krivard
krivard approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@krivard krivard merged commit 74e9fbc into dev Feb 24, 2022
@krivard krivard deleted the dsew_vacc_api branch February 24, 2022 20:58
@krivard krivard mentioned this pull request Feb 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krivard krivard krivard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ananya-Joshi @nmdefries @krivard