Skip to content

Add documentation for new Community Profile Report indicator #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 1, 2022

Conversation

nmdefries
Copy link
Contributor

@nmdefries nmdefries commented Jan 25, 2022

Summary

Document CPR indicator with hospital admissions signal.

Copy link
Contributor

@capnrefsmmat capnrefsmmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this page explicitly address how this data is different from our hhs and hospital-admissions sources? We now have three sources with hospital-related data and I don't know if users will be able to distinguish them. (For instance, I'm out of the loop, so I don't know how this is different from the HHS signals we already publish.)

Also, do we not have prop signals for this source?

Co-authored-by: Alex Reinhart <[email protected]>
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Draft of clarifications requested by @capnrefsmmat

Includes reference to results from Maria's analysis, which we may want to make available publicly. @mariajahja or @ryantibs , any corrections or objections?

nmdefries and others added 2 commits January 28, 2022 16:59
@nmdefries
Copy link
Contributor Author

We are not adding prop signals at this time.

@nmdefries nmdefries marked this pull request as ready for review January 28, 2022 23:13
@ryantibs
Copy link
Member

I would remove the reference to the statement that a copy of the analysis is available. Otherwise, I think it's fine to refer specifically what we found (comparing HHS to CPR).

No prop signals: that will be problematic, because we're intending to show this on the COVIDcast dashboard (for county-level hospital admissions), and we will need prop signals for that.

Copy link
Contributor

@capnrefsmmat capnrefsmmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation seems clear enough (except one comment on license), modulo Ryan's concerns

@krivard krivard merged commit ef4f380 into dev Feb 1, 2022
@krivard krivard deleted the ndefries/new-cpr-docs branch February 1, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants