Limit rows returned for correlations #704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add row limit to the request before forming dataframe * add tests
* wrote test to ensure row limits work
krivard
reviewed
Sep 8, 2021
* add test magic so as_pandas can be called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses this comment #646 (comment).
Prerequisites:
devbranchdevSummary
Currently, the
/correlationsendpoint in covidcast bypasses the row limits requirements by passing the query directly topd.read_sql_query. This PR abstracts row limiting fromrun_queryand adds it toas_pandas. A test to make sure it works is provided.There may be a possible issue where someone requests too many rows and the row limit leads to the two correlated time series being mismatched, which would likely lead to an Exception later in the correlation code. We could try and send an error message if the number of returned rows == MAX_RESULTS instead of proceeding, getting an error, and sending nothing.