Skip to content

ci: require build to be successful before creating image #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 5, 2021
Merged

ci: require build to be successful before creating image #517

merged 3 commits into from
May 5, 2021

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented May 5, 2021

to avoid creating faulty images

@sgratzl sgratzl self-assigned this May 5, 2021
@sgratzl sgratzl added the chore label May 5, 2021
@sgratzl sgratzl requested a review from krivard May 5, 2021 14:23
@sgratzl sgratzl changed the base branch from dev to main May 5, 2021 14:40
@korlaxxalrok korlaxxalrok self-requested a review May 5, 2021 14:50
korlaxxalrok
korlaxxalrok approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@korlaxxalrok korlaxxalrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@korlaxxalrok korlaxxalrok merged commit abf18dd into main May 5, 2021
@korlaxxalrok korlaxxalrok deleted the sgratzl/ci_fix branch May 5, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korlaxxalrok korlaxxalrok korlaxxalrok approved these changes

@krivard krivard Awaiting requested review from krivard

Assignees

@sgratzl sgratzl

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgratzl @korlaxxalrok