Skip to content

facility fix and new endpoint #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2020

Conversation

dfarrow0
Copy link
Contributor

  • bool('false') is True
  • add a helper function to parse bool from str, allowing missing and
    empty values

note that prod database needs to be backfilled since previous
acquisitions incorrectly casted 'false' and 'true' both to True


  • the hhs covid hosp dataset is keyed by hospital_pk, which is a
    unique identifier for healthcare facilities.
  • the key is not generally well-known, but querying the
    covid_hosp_facility dataset requires key(s)
  • the new endpoint returns facility information (including key) for
    given regions (e.g. city, state, zip, ccn, fips)
  • users would be expected to lookup hospitals of interest e.g. by state
    or city. then query covid_hosp_facility with the key for those
    hospitals.
  • server and clients updated
  • all unit and integrations pass

note that new indexes are added to the database to facilitate fast
lookups. otherwise it would be a full table scan each time, which does
not scale well. indexes are expected to be very small.

- `bool('false')` is `True`
- add a helper function to parse bool from str, allowing missing and 
empty values

note that prod database needs to be backfilled since previous 
acquisitions incorrectly casted 'false' and 'true' both to `True`
- the hhs covid hosp dataset is keyed by `hospital_pk`, which is a 
unique identifier for healthcare facilities.
- the key is not generally well-known, but querying the 
`covid_hosp_facility` dataset requires key(s)
- the new endpoint returns facility information (including key) for 
given regions (e.g. city, state, zip, ccn, fips)
- users would be expected to lookup hospitals of interest e.g. by state 
or city. then query `covid_hosp_facility` with the key for those 
hospitals.
- server and clients updates
- all unit and integrations pass

note that new indexes are added to the database to facilitate fast 
lookups. otherwise it would be a full table scan each time, which does 
not scale well. indexes are expected to be very small.
@krivard krivard requested a review from chinandrew December 17, 2020 22:34
Copy link
Contributor

@chinandrew chinandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit::shipit::shipit:

@chinandrew
Copy link
Contributor

does a list of states work here or do they have to be individual?

@dfarrow0
Copy link
Contributor Author

here they would be individual states. i'm not opposed to making that a list of states if it's useful, but prefer to defer that as a followup

@chinandrew
Copy link
Contributor

here they would be individual states. i'm not opposed to making that a list of states if it's useful, but prefer to defer that as a followup

makes sense, sounds fine to leave as is

@krivard krivard merged commit 64f96f8 into cmu-delphi:main Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants