Skip to content

Change CLI docs #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 8, 2020
Merged

Change CLI docs #306

merged 4 commits into from
Dec 8, 2020

Conversation

rumackaaron
Copy link
Contributor

@rumackaaron rumackaaron commented Dec 2, 2020 •
edited by krivard
Loading

part of cmu-delphi/covidcast-indicators#591. Wait to merge until CHNG CLI is running in production.

@rumackaaron rumackaaron requested a review from krivard December 2, 2020 21:32
@krivard krivard requested a review from Akvannortwick December 2, 2020 21:32
@rumackaaron rumackaaron removed the request for review from krivard December 2, 2020 21:32
krivard
krivard suggested changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple signals, multiple estimators, best to be clear

krivard
krivard approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Akvannortwick
Akvannortwick reviewed Dec 2, 2020
View reviewed changes
@krivard krivard merged commit 38ff1f5 into main Dec 8, 2020
@krivard krivard deleted the chng-cli-docs branch December 8, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krivard krivard krivard approved these changes

@Akvannortwick Akvannortwick Akvannortwick left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rumackaaron @krivard @Akvannortwick