Skip to content

Fb survey fix changelog #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 30, 2020

Conversation

Akvannortwick
Copy link
Contributor

No description provided.

Copy link
Contributor

@capnrefsmmat capnrefsmmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, just a couple suggested minor fixes

@@ -1,4 +1,4 @@
---
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is probably unintentional and should be un-done, since I think it'll mess up the Markdown formatting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops sorry about that, will do.

#### 20 November 2020

Due to a bug in our data processing system, estimates of the percentage of people reporting that they have been tested for COVID-19 calculated before October 8th were incorrect.
We incorrectly treated an answer of “no” as a missing response, which affected the smoothed_tested_14d and smoothed_wtested_14d signals from the fb-survey source.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We incorrectly treated an answer of “no” as a missing response, which affected the smoothed_tested_14d and smoothed_wtested_14d signals from the fb-survey source.
We incorrectly treated an answer of “no” as a missing response, which affected the `smoothed_tested_14d` and `smoothed_wtested_14d` signals from the `fb-survey` source.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically put source and signal names in monospace font, which the backticks do

Copy link
Contributor

@capnrefsmmat capnrefsmmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay

@capnrefsmmat capnrefsmmat merged commit 7e43e33 into cmu-delphi:main Nov 30, 2020
@Akvannortwick Akvannortwick deleted the Fb-Survey-fix-changelog branch November 30, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants