Skip to content

Add API doc for Google-Symptoms indicator #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 30, 2020
Merged

Add API doc for Google-Symptoms indicator #273

merged 12 commits into from
Nov 30, 2020

Conversation

jingjtang
Copy link
Contributor

  • Estimation section for combined_symptoms signal
  • Description for combined_symptoms signal

Still wait for Roni's decision on this.

The rest of it is ready for a review.

@jingjtang
Copy link
Contributor Author

Issue here

Copy link
Contributor

@capnrefsmmat capnrefsmmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize this isn't done; just some suggestions

Comment on lines 19 to 20
search term within a geographic region. Thus, values are not comparable between
geographic regions. Larger numbers represent higher numbers of symptom-related
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it true that values are not comparable between geographic regions, and you can only use time series in one region? I thought the population normalization was supposed to make them comparable somehow.

If they're not comparable, that's a pretty big caveat, and probably deserves its own paragraph with a bold Warning label.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they are not comparable across regions since they are scaled by regional specific maximum value at a certain time point.

@krivard krivard changed the base branch from main to docs/1.11 November 18, 2020 14:38
@krivard krivard merged commit ab168df into cmu-delphi:docs/1.11 Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants