mod changelog to incorporate JHU geocoding #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this also explained in the JHU signal page? It has a list of coding exceptions, and I'm not sure if that's up-to-date. |
It is not! I'll propose modification to that as well then |
|
I'd also recommend taking a look at the overall geocoding page to make sure it's still correct |
|
I added some more JHU documentation changes in the changelog and in the JHU geocoding page. (I also incremented the "number of data revisions since ... " field, assuming this counts as a data revision.) |
* include that Puerto Rico are only available at state level * remove NYC special case, as it's no longer needed
* Add Utah health departments information
|
Should we increment the "number of data revisions since ... " field? Not
sure what constitutes a data revision.
No; that field pre-dates the data versioning system. At some point we
should overhaul all the documentation to remove it, but that's beyond the
scope of this PR.
|
|
@krivard the overall geocoding page looks good to me, though I'm not that familiar with the megacounty privacy mapping. |
krivard
suggested changes
Oct 2, 2020
* Update inconsistencies about population splits * Update mangled sentece in Puerto RIco
krivard
approved these changes
Oct 5, 2020
krivard
reviewed
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Geomapping refactoring of the indicators codebase have changed the meaning or calculation of some FIPS or State totals