Skip to content

timeformats #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 8, 2020
Merged

timeformats #183

merged 4 commits into from
Sep 8, 2020

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Aug 10, 2020

closes #180

@krivard
Copy link
Contributor

krivard commented Aug 12, 2020

#187 is imminent and takes priority; @melange396 or I can assist with conflict resolution once it is merged.

@krivard
Copy link
Contributor

krivard commented Sep 4, 2020

@sgratzl thanks for your patience here.

I did a test merge with main and it generated the following failing integration test:

Warning: repos.delphi.delphi-epidata.integrations.server.test_covidcast missing attribute __test_target__. Coverage will not be tracked.
test_date_formats (repos.delphi.delphi-epidata.integrations.server.test_covidcast.CovidcastTests)
Request a signal using different time formats. ... ERROR
test_location_timeline (repos.delphi.delphi-epidata.integrations.server.test_covidcast.CovidcastTests)
Select a timeline for a particular location. ... ok
test_location_wildcard (repos.delphi.delphi-epidata.integrations.server.test_covidcast.CovidcastTests)
Select all locations with a wildcard query. ... ok
test_nullable_columns (repos.delphi.delphi-epidata.integrations.server.test_covidcast.CovidcastTests)
Missing values should be surfaced as null. ... ok
test_round_trip (repos.delphi.delphi-epidata.integrations.server.test_covidcast.CovidcastTests)
Make a simple round-trip with some sample data. ... ok
test_temporal_partitioning (repos.delphi.delphi-epidata.integrations.server.test_covidcast.CovidcastTests)
Request a signal that's available at multiple temporal resolutions. ... ok
test_unique_key_constraint (repos.delphi.delphi-epidata.integrations.server.test_covidcast.CovidcastTests)
Don't allow a row with a key collision to be inserted. ... ok

======================================================================
ERROR: test_date_formats (repos.delphi.delphi-epidata.integrations.server.test_covidcast.CovidcastTests)
Request a signal using different time formats.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/src/app/repos/delphi/delphi-epidata/integrations/server/test_covidcast.py", line 339, in test_date_formats
    self.cur.execute('''
  File "/usr/local/lib/python3.8/site-packages/mysql/connector/cursor.py", line 551, in execute
    self._handle_result(self._connection.cmd_query(stmt))
  File "/usr/local/lib/python3.8/site-packages/mysql/connector/connection.py", line 490, in cmd_query
    result = self._handle_result(self._send_cmd(ServerCmd.QUERY, query))
  File "/usr/local/lib/python3.8/site-packages/mysql/connector/connection.py", line 395, in _handle_result
    raise errors.get_exception(packet)
mysql.connector.errors.DataError: 1136 (21S01): Column count doesn't match value count at row 1

----------------------------------------------------------------------
Ran 7 tests in 0.196s

FAILED (errors=1)

Take a look?

@sgratzl
Copy link
Member Author

sgratzl commented Sep 7, 2020

@krivard krivard merged commit 5183f9d into cmu-delphi:main Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consider adding support for ISO date format: yyyy-mm-dd
2 participants