Skip to content

fix: simplify client version check #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2024
Merged

fix: simplify client version check #1498

merged 1 commit into from
Jul 24, 2024

Conversation

dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Jul 19, 2024 •
edited
Loading

Changes from this comment.

@dshemetov dshemetov requested a review from melange396 July 19, 2024 19:12
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@dshemetov dshemetov requested review from rzats and minhkhul July 19, 2024 20:05
minhkhul
minhkhul approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@minhkhul minhkhul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@minhkhul minhkhul merged commit ca5d74d into pyclient_vercheck_fix Jul 24, 2024
7 checks passed
@minhkhul minhkhul deleted the pyclient_fix_fix branch July 24, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minhkhul minhkhul minhkhul approved these changes

@melange396 melange396 Awaiting requested review from melange396

@rzats rzats Awaiting requested review from rzats

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dshemetov @minhkhul