Skip to content

docs: very minor dev doc update #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2024
Merged

docs: very minor dev doc update #1491

merged 2 commits into from
Jul 10, 2024

Conversation

dshemetov
Copy link
Contributor

cleans up comments from #1466

Summary:

Add a helpful docker command.

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@dshemetov dshemetov requested a review from melange396 July 9, 2024 17:55
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

melange396
melange396 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic, thanks!

@melange396 melange396 merged commit 5f23936 into dev Jul 10, 2024
7 checks passed
@melange396 melange396 deleted the dshemetov-patch-1 branch July 10, 2024 01:36
@minhkhul minhkhul mentioned this pull request Jul 18, 2024
Closed
@minhkhul minhkhul mentioned this pull request Jul 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melange396 melange396 melange396 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dshemetov @melange396