-
Notifications
You must be signed in to change notification settings - Fork 67
fix(pyclient ci): validate version arg in create-release #1473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dshemetov
merged 2 commits into
rzatserkovnyi/client-release-decouple
from
ds/bump-version
Jun 18, 2024
Merged
fix(pyclient ci): validate version arg in create-release #1473
dshemetov
merged 2 commits into
rzatserkovnyi/client-release-decouple
from
ds/bump-version
Jun 18, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
c8dfda7
to
156c21e
Compare
156c21e
to
1f50b0b
Compare
melange396
reviewed
Jun 7, 2024
rzats
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
melange396
requested changes
Jun 17, 2024
melange396
reviewed
Jun 18, 2024
* add comments * revert bumpversion configs Co-authored-by: george <[email protected]>
d7f8be8
to
9d3a9ca
Compare
|
Cleaned up the commit log by squashing the edits. |
e41c741
into
rzatserkovnyi/client-release-decouple
6 checks passed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Started from this conversation.
Fix the release CI to accept any version number and major, minor, patch as its argument. My test script for the versionNumber logic is below.
Notes:
pip install -r requirements.api.txt -r requirements.dev.txt
in our Dockerfile.Prerequisites:
dev
branchdev