-
Notifications
You must be signed in to change notification settings - Fork 67
feat: port pyclient build config to pyproject.toml #1470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
fd49297
feat: port pyclient build config to pyproject.toml
dshemetov f77a033
Update src/client/packaging/pypi/pyproject.toml
dshemetov 8242542
Update src/client/packaging/pypi/pyproject.toml
dshemetov 1702541
Update src/client/packaging/pypi/pyproject.toml
dshemetov 05c24a4
Update src/client/packaging/pypi/pyproject.toml
dshemetov 5964414
Update src/client/packaging/pypi/pyproject.toml
dshemetov 11736ec
Update src/client/packaging/pypi/pyproject.toml
dshemetov 2e9a06c
fix: remove setuptools version pin and python >= 3.8 req
dshemetov 685fb1e
fix: omit dev version classifier metadata for pyclient
dshemetov 19bfff4
fix: small formats to pyclient build config
dshemetov 3fd491a
fix: add python 2 support to our classification
dshemetov d81fa59
fix(client)+doc: update ci and changelog
dshemetov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,118 @@ | ||
# Guide (user-friendly): | ||
# https://packaging.python.org/en/latest/guides/writing-pyproject-toml/ | ||
|
||
# Specification (technical, formal): | ||
# https://packaging.python.org/en/latest/specifications/pyproject-toml/ | ||
|
||
|
||
# Choosing a build backend: | ||
# https://packaging.python.org/en/latest/tutorials/packaging-projects/#choosing-a-build-backend | ||
[build-system] | ||
# A list of packages that are needed to build your package: | ||
requires = ["setuptools>=61.0.0"] # REQUIRED if [build-system] table is used | ||
# The name of the Python object that frontends will use to perform the build: | ||
build-backend = "setuptools.build_meta" # If not defined, then legacy behavior can happen. | ||
|
||
|
||
[project] | ||
# This is the name of your project. The first time you publish this | ||
# package, this name will be registered for you. It will determine how | ||
# users can install this project, e.g.: | ||
# | ||
# $ pip install sampleproject | ||
# | ||
# And where it will live on PyPI: https://pypi.org/project/sampleproject/ | ||
# | ||
# There are some restrictions on what makes a valid project name | ||
# specification here: | ||
# https://packaging.python.org/specifications/core-metadata/#name | ||
name = "delphi_epidata" # REQUIRED, is the only field that cannot be marked as dynamic. | ||
|
||
# Versions should comply with PEP 440: | ||
# https://www.python.org/dev/peps/pep-0440/ | ||
# | ||
# For a discussion on single-sourcing the version, see | ||
# https://packaging.python.org/guides/single-sourcing-package-version/ | ||
version = "4.1.23" | ||
|
||
# This is a one-line description or tagline of what your project does. This | ||
# corresponds to the "Summary" metadata field: | ||
# https://packaging.python.org/specifications/core-metadata/#summary | ||
description = "A programmatic interface to Delphi's Epidata API." | ||
|
||
# This is an optional longer description of your project that represents | ||
# the body of text which users will see when they visit PyPI. | ||
# | ||
# Often, this is the same as your README, so you can just read it in from | ||
# that file directly. | ||
# | ||
# This field corresponds to the "Description" metadata field: | ||
# https://packaging.python.org/specifications/core-metadata/#description-optional | ||
readme = "README.md" | ||
|
||
# Specify which Python versions you support. In contrast to the | ||
# 'Programming Language' classifiers in this file, 'pip install' will check this | ||
# and refuse to install the project if the version does not match. See | ||
# https://packaging.python.org/guides/distributing-packages-using-setuptools/#python-requires | ||
dshemetov marked this conversation as resolved.
Show resolved
Hide resolved
|
||
requires-python = ">=3.8" | ||
dshemetov marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
# This is either text indicating the license for the distribution, or a file | ||
# that contains the license. | ||
# https://packaging.python.org/en/latest/specifications/core-metadata/#license | ||
license = { file = "LICENSE.txt" } | ||
dshemetov marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
# This should be your name or the name of the organization who originally | ||
# authored the project, and a valid email address corresponding to the name | ||
# listed. | ||
dshemetov marked this conversation as resolved.
Show resolved
Hide resolved
|
||
authors = [{ name = "David Farrow", email = "[email protected]" }] | ||
|
||
# This should be your name or the names of the organization who currently | ||
# maintains the project, and a valid email address corresponding to the name | ||
# listed. | ||
# maintainers = [ | ||
# { name = "A. Great Maintainer", email = "[email protected]" }, | ||
# ] | ||
dshemetov marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
# Classifiers help users find your project by categorizing it. | ||
# | ||
# For a list of valid classifiers, see https://pypi.org/classifiers/ | ||
classifiers = [ | ||
# How mature is this project? Common values are | ||
# 3 - Alpha | ||
# 4 - Beta | ||
# 5 - Production/Stable | ||
# Pick your license as you wish | ||
"License :: OSI Approved :: MIT License", | ||
|
||
# Specify the Python versions you support here. In particular, ensure | ||
# that you indicate you support Python 3. These classifiers are *not* | ||
# checked by "pip install". See instead "requires-python" key in this file. | ||
"Programming Language :: Python", | ||
"Operating System :: OS Independent", | ||
"Intended Audience :: Science/Research", | ||
"Natural Language :: English", | ||
"Topic :: Scientific/Engineering :: Bio-Informatics", | ||
] | ||
dshemetov marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
# This field lists other packages that your project depends on to run. | ||
# Any package you put here will be installed by pip when your project is | ||
# installed, so they must be valid existing projects. | ||
# | ||
# For an analysis of this field vs pip's requirements files see: | ||
# https://packaging.python.org/discussions/install-requires-vs-requirements/ | ||
dependencies = ["aiohttp", "delphi-utils", "requests>=2.7.0", "tenacity"] | ||
|
||
|
||
# List URLs that are relevant to your project | ||
# | ||
# This field corresponds to the "Project-URL" and "Home-Page" metadata fields: | ||
# https://packaging.python.org/specifications/core-metadata/#project-url-multiple-use | ||
# https://packaging.python.org/specifications/core-metadata/#home-page-optional | ||
# | ||
# Examples listed include a pattern for specifying where the package tracks | ||
# issues, where the source is hosted, where to say thanks to the package | ||
# maintainers, and where to support the project financially. The key is | ||
# what's used to render the link text on PyPI. | ||
dshemetov marked this conversation as resolved.
Show resolved
Hide resolved
|
||
[project.urls] | ||
"Homepage" = "https://github.com/cmu-delphi/delphi-epidata" | ||
"Changelog" = "https://github.com/cmu-delphi/delphi-epidata/blob/main/src/client/packaging/pypi/CHANGELOG.md" |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does that version get us? the sample/template
pyproject.toml
doesnt specify itThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yea, it's not necessary here, I'll remove it. It's needed to support the dynamic version feature (see the callout box in bullet 1 here "As of the release of setuptools 61.0.0..."). I used it in delphi-logger though and it works!