Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nssp documentation draft #1439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nssp documentation draft #1439
Changes from 8 commits
af3a96b
dc918b6
a65a808
0d1d2a2
6a3eadd
fff0654
761a808
889abe1
6360508
2a45528
28482cf
a028cbe
cafa9d6
fb7c54d
585fbc3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: this is late in the game, so optional change, but signal names would be clearer as
pct_er_visits_*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pct_ed_visits_*
? I'm still not sure about the difference tbh. I'd leave it up to Minh, as she'd have the most to change.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was considering "ed", but it's not how laypeople refer to it. As far as I'm aware, only healthcare workers call the ER the "ED". So I think for a more general audience, "er" is clearer, although it does differ from the dataset name.
Will ask Roni
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nmdefries, sorry I'm late here!
Minor suggestion: In the TOC, consider adding a link to the "Overview" to maintain consistency with the TOCs of signals such as "Change Healthcare" and "Doctor Visits".
Nothing else stands out, the headings are great. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for looking! Though I don't really follow what you mean. When I look at the table of contents in
doctor-visits
:delphi-epidata/docs/api/covidcast-signals/doctor-visits.md
Lines 30 to 36 in e423cb4
it seems just the same as what's here?
delphi-epidata/docs/api/covidcast-signals/nssp.md
Lines 35 to 40 in 28482cf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for a response from Roni about naming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dsweber2 sorry for the confusion: you can prob just ignore my comment! I think the "Overview" section I'm pointing to may be contained in the {:toc} . Here's a visual where in doctor's visits the TOC has "Overview" circled in red:

Thanks!