Switch to Sentry #1345
Merged
Switch to Sentry #1345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Delete the wrapper file - Don't copy the wrapper into the Docker image
Adds imports for - `os` for access to the system environment - `sentry_sdk` for Sentry goodness Adds a default Sentry config that is useful and verbose for development - This will only be enabled if a Sentry DSN is supplied, otherwise it is ignored - These defaults can/will be turned down a bit for production via our config repo
- Updates our Makefile with a new target to create an empty .env file if one does not already exist. If one already exists it won't be altered. - Updates the `web:` target to use the .env file when starting the container.
melange396
reviewed
Nov 10, 2023
Co-authored-by: melange396 <[email protected]>
|
I want to work on this a bit more so converting to draft for a little bit. |
korlaxxalrok
force-pushed
the
remove-newrelic-add-sentry
branch
from
1aab7a4 to
b7be446
Compare
- Set `debug` and `attach_stacktrace` to `False` - Reordered a bit - Added a decent way to make an env var work as a boolean - Better formatting (spaces around `=`)
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We are migrating to Sentry for application observability needs.
The goal is to use it for both local development as well as (potentially) qa/staging/production/etc. environments.
This PR:
Removes and cleans up the New Relic config:
Adds the necessary Sentry bits:
Updates the local development setup to make it easy to instrument for Sentry (if desired):
.envfile if one doesn't already exist. We need to be able to pass in the Sentry DSN (and maybe other config), and putting this into.envis best.delphi_web_epidatawith--env-fileto load vars from.envAdds comments and README updates to help with a basic Sentry setup in:
.env.exampleepidata_development.md