Skip to content

Fix as_of for date range #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2023
Merged

Fix as_of for date range #1300

merged 2 commits into from
Oct 9, 2023

Conversation

dmytrotsko
Copy link
Contributor

Summary:

Made as_of query to fail with a helpful error message if len(as_of) > 10

Prerequisites:

  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@dmytrotsko dmytrotsko linked an issue Oct 6, 2023 that may be closed by this pull request
covidcast endpoint - as_of field fails silently when given a range of dates #1152
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

dshemetov
dshemetov approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@dshemetov dshemetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dmytrotsko dmytrotsko merged commit d42517e into dev Oct 9, 2023
@dmytrotsko dmytrotsko deleted the 1152-covidcast-endpoint-as_of-field-fails-silently-when-given-a-range-of-dates branch October 9, 2023 13:41
@melange396 melange396 mentioned this pull request Oct 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshemetov dshemetov dshemetov approved these changes

@melange396 melange396 Awaiting requested review from melange396

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

covidcast endpoint - as_of field fails silently when given a range of dates
2 participants
@dmytrotsko @dshemetov