Skip to content

#1015 ci delete deprecated set output #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 21, 2023

Conversation

BrainIsDead
Copy link
Contributor

closes|addresses #1015

Summary:

  • Modified .github/workflows/create-release.yml to update the echo -n $next_tag line to echo -n "next_tag={next_tag}" >> $GITHUB_OUTPUT
  • Modified .github/workflows/release-helper.yml to update the echo -n $version line to echo -n "version={version}" >> $GITHUB_OUTPUT

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

- Updated the version of the `actions/checkout` action from `v2` to `v3` in the `.github/workflows/ci.yaml` file.
- Modified the checkout step for multiple repositories to use the `actions/checkout@v3` action.
- Updated the checkout step for the `src/client/packaging/npm` directory to use the `actions/checkout@v3` action.
- Updated the checkout step for the code in the `jobs.build` section to use the `actions/checkout@v3` action.
- Added a step to set the output variables `tag` and `repo` in the `jobs.build` section.

These changes update the workflow to use the latest version of the `actions/checkout` action and ensure that the code is checked out correctly for each repository.
- Updated the version of the `actions/checkout` action from `v2` to `v3` in the `.github/workflows/create-release.yml`, `.github/workflows/missing_signals.yaml`, `.github/workflows/release-helper.yml`, and `.github/workflows/update_gdocs_data.yml` files.
- Updated the version of the `actions/setup-python` action from `v2` to `v4` in the `.github/workflows/create-release.yml`, `.github/workflows/missing_signals.yaml`, `.github/workflows/release-helper.yml`, and `.github/workflows/update_gdocs_data.yml` files.
- Removed the line `echo -n "::set-output name=next_tag::"` and replaced it with `echo -n $next_tag >> $GITHUB_OUTPUT` in the `.github/workflows/create-release.yml` file.
- Removed the line `echo -n "::set-output name=version::"` and replaced it with `echo -n $version >> $GITHUB_OUTPUT` in the `.github/workflows/release-helper.yml` file.
- Added `.github/workflows/create-release.yml`
- Modified `.github/workflows/create-release.yml` to update the `echo -n $next_tag` line to `echo -n "next_tag={next_tag}" >> $GITHUB_OUTPUT`
- Modified `.github/workflows/release-helper.yml` to update the `echo -n $version` line to `echo -n "version={version}" >> $GITHUB_OUTPUT`
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catches!

@melange396 melange396 merged commit 09036ab into dev Aug 21, 2023
@melange396 melange396 deleted the #1015--CI-delete-deprecated-set-output branch August 21, 2023 15:29
melange396 added a commit that referenced this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants