-
Notifications
You must be signed in to change notification settings - Fork 67
Created maintenance pkg & added APIKey usage maintenance jobs. #1223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created maintenance pkg & added APIKey usage maintenance jobs. #1223
Conversation
Added new scripts for API Keys maintenance. Deleted: * src/acquisition/covidcast/generate_islatest_fix_sql.py * src/acquisition/covidcast/islatest_fix.sql * src/acquisition/covidcast/migrate_epidata_to_v4.py Moved from acquisition to maintenance: * src/acquisition/covidcast/covidcast_meta_cache_updater.py * src/acquisition/covidcast/delete_batch.py * src/acquisition/covidcast/signal_dash_data_generator.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks pretty good, but i think its still missing a few things for api key management.
in addition to what i commented on in the code, we might want to clear out keys (from redis) with usages older than "today" as part of update_last_usage.py
.
…global LAST_USED_KEY_PATTERN. Deleted function and moved filtering login to the update query in
19c9ad2
to
852312c
Compare
Added .starttls() to the smtp server.
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work!
i think we will want to run some of the user-facing text past Roni, but we can merge this in the meantime since it wont email anyone for a few months at least.
Summary:
Added new scripts for API Keys maintenance.
Moved from acquisition to maintenance:
Deleted:
Prerequisites:
dev
In Cronicle (right before or after doing a release of that new code):