Skip to content

Created maintenance pkg & added APIKey usage maintenance jobs. #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dmytrotsko
Copy link
Contributor

@dmytrotsko dmytrotsko commented Jun 29, 2023

Summary:

Added new scripts for API Keys maintenance.
Moved from acquisition to maintenance:

  • src/acquisition/covidcast/covidcast_meta_cache_updater.py
  • src/acquisition/covidcast/delete_batch.py
  • src/acquisition/covidcast/signal_dash_data_generator.py

Deleted:

  • src/acquisition/covidcast/generate_islatest_fix_sql.py
  • src/acquisition/covidcast/islatest_fix.sql
  • src/acquisition/covidcast/migrate_epidata_to_v4.py

Prerequisites:

  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

In Cronicle (right before or after doing a release of that new code):

  • update job scripts to point to new packages for maintenance tasks
    • covidcast_meta_cache_updater.py
    • signal_dash_data_generator.py
    • delete_batch.py
  • add 2 new api key tasks

Added new scripts for API Keys maintenance.
Deleted:
 * src/acquisition/covidcast/generate_islatest_fix_sql.py
 * src/acquisition/covidcast/islatest_fix.sql
 * src/acquisition/covidcast/migrate_epidata_to_v4.py
Moved from acquisition to maintenance:
 * src/acquisition/covidcast/covidcast_meta_cache_updater.py
 * src/acquisition/covidcast/delete_batch.py
 * src/acquisition/covidcast/signal_dash_data_generator.py
@dmytrotsko dmytrotsko requested a review from melange396 June 29, 2023 20:57
@dmytrotsko dmytrotsko self-assigned this Jun 29, 2023
Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good, but i think its still missing a few things for api key management.

in addition to what i commented on in the code, we might want to clear out keys (from redis) with usages older than "today" as part of update_last_usage.py.

@dmytrotsko dmytrotsko force-pushed the AK-127-figure-out-where-to-put-api-key-maintenance-util branch from 19c9ad2 to 852312c Compare July 26, 2023 18:58
@dmytrotsko dmytrotsko requested a review from melange396 July 27, 2023 20:23
@dmytrotsko dmytrotsko requested a review from melange396 July 31, 2023 12:53
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

i think we will want to run some of the user-facing text past Roni, but we can merge this in the meantime since it wont email anyone for a few months at least.

@melange396 melange396 changed the title Created maintenance folder. Created maintenance pkg & added APIKey usage maintenance jobs. Aug 1, 2023
@melange396 melange396 merged commit d38cde5 into dev Aug 1, 2023
@melange396 melange396 deleted the AK-127-figure-out-where-to-put-api-key-maintenance-util branch August 1, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants