Skip to content

Drop phase handling #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2023
Merged

Drop phase handling #1210

merged 2 commits into from
Jul 10, 2023

Conversation

dmytrotsko
Copy link
Contributor

Summary:

Dropped phase handling for API keys

Prerequisites:

  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@dmytrotsko dmytrotsko requested a review from melange396 June 26, 2023 15:22
melange396
melange396 previously approved these changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! i noticed one old "phase" comment line that can be removed, but this is great otherwise!

@dmytrotsko @melange396
Remove "phase" comment
6e6db5d 
Co-authored-by: melange396 <[email protected]>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

melange396
melange396 approved these changes Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@melange396 melange396 merged commit 376c877 into dev Jul 10, 2023
@melange396 melange396 deleted the ak-107_drop_phase_handling branch July 10, 2023 23:23
@BrainIsDead BrainIsDead mentioned this pull request Jul 13, 2023
Merged
dmytrotsko added a commit that referenced this pull request Jul 26, 2023
@dmytrotsko
Drop phase handling (#1210)
90af72e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melange396 melange396 melange396 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmytrotsko @melange396