Added UNIQUE KEYS to fluview_clinical to avoid duplicates #1127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melange396
previously approved these changes
Apr 7, 2023
krivard
suggested changes
Apr 7, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
krivard
reviewed
Apr 10, 2023
…l table. Added new constraint creation
dmytrotsko
requested review from
krivard and
melange396
and removed request for
melange396
melange396
requested changes
Jun 15, 2023
…alculation correct. Changed issue to release_date in ON DUPLICATE KEY UPDATE secion for table.
…pulate it with only unique rows from original `fluview_clinical` table. Added statement to remove duplicates from `fluview_clinical` table. Added `issue` index drop on `fluview_clinical` table with with the following creation of new one that is based on (`issue`, `epiweek`, `region`).
melange396
requested changes
Jun 21, 2023
Comment on lines
115
to
118
| -- Before creating new unique constraint we need to remove rows that do not satisfy it. | ||
| DELETE FROM | ||
| fluview_clinical | ||
| WHERE |
There was a problem hiding this comment.
this is just a reminder that we can remove the fluview_clinical table, and then rename fluview_clinical_v2 back to fluview_clinical instead of this
Co-authored-by: melange396 <[email protected]>
Co-authored-by: melange396 <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes
Prerequisites:
devbranchdevSummary
Added UNIQUE KEY constraints to epidata.fluview_clinical to avoid duplicate rows.
Before that, we need to delete duplicates:
DELETE FROM fluview_clinical WHERE id in ( SELECT dup.id FROM ( SELECT * FROM ( SELECT fc.id, fc.release_date, fc.issue, fc.epiweek, fc.region, fc.lag, fc.total_specimens, fc.total_a, fc.total_b, fc.percent_positive, fc.percent_a, fc.percent_b, ROW_NUMBER() OVER ( PARTITION BY fc.release_date,fc.issue,fc.epiweek,fc.region,fc.lag,fc.total_specimens,fc.total_a,fc.total_b,fc.percent_positive,fc.percent_a,fc.percent_b ORDER BY fc.release_date ) as row_num FROM epidata.fluview_clinical fc ORDER BY fc.release_date DESC ) s WHERE s.row_num > 1 ) dup );