Automatically parse columns from YAML file #1114
Conversation
|
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
There was a problem hiding this comment.
this is not a bad start, but its got a ways to go. you can leave the stuff related to my comments on filenames and deeper structural changes to src/acquisition/covid_hosp/*/database.py alone for the most part right now, but we will need to refer back to them later after more things are integrated and merged.
|
Kudos, SonarCloud Quality Gate passed!
|
|
@melange396 fixed most issues except one around reading the static YAML file which I left a comment about! |
…, and readd method to write that file Co-authored-by: rzats <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
* Automatically parse columns from YAML file * Use constructor * try alt filename * Try absolute path * AGGREGATE_KEY_COLS * what if none aggregate? * fix table name * tests * ordered csv * use cols method * try pkgutil * cleanup unneeded methods * Review fixes * Revert to old filename processing * thread the name of the yaml schemadefs file through the whole process, and readd method to write that file Co-authored-by: rzats <[email protected]> --------- Co-authored-by: george haff <[email protected]>
* Automatically parse columns from YAML file * Use constructor * try alt filename * Try absolute path * AGGREGATE_KEY_COLS * what if none aggregate? * fix table name * tests * ordered csv * use cols method * try pkgutil * cleanup unneeded methods * Review fixes * Revert to old filename processing * thread the name of the yaml schemadefs file through the whole process, and readd method to write that file Co-authored-by: rzats <[email protected]> --------- Co-authored-by: george haff <[email protected]>
* Automatically parse columns from YAML file * Use constructor * try alt filename * Try absolute path * AGGREGATE_KEY_COLS * what if none aggregate? * fix table name * tests * ordered csv * use cols method * try pkgutil * cleanup unneeded methods * Review fixes * Revert to old filename processing * thread the name of the yaml schemadefs file through the whole process, and readd method to write that file Co-authored-by: rzats <[email protected]> --------- Co-authored-by: george haff <[email protected]>
Note: this is against the
group/covid_hosp_auto_columnsbranch - not dev.Prerequisites:
devbranchdevSummary
Update to @melange396's
covid_hospschema code:facility,state_daily&state_timeseriesdefinitions