Skip to content

change github perftest workflow to use as_of query set #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

melange396
Copy link
Collaborator

this changes the github action/workflow for performance testing to use the "as_of" set of sample queries.

question: will this need to be merged into the main branch before the action/workflow uses the new query set, or will it work after being merged into dev?

@melange396 melange396 requested a review from rzats March 15, 2023 14:53
@melange396
Copy link
Collaborator Author

/run performance test

@rzats
Copy link
Contributor

rzats commented Mar 15, 2023

@melange396 during testing it worked after being merged into dev. (However, the changes won't be reflected in the run made by the comment you left just now)

@github-actions
Copy link
Contributor

✅ Performance tests complete! Result summary:

  • Total requests: 1000
  • Total failures: 2
  • Min response time: 23.36 ms
  • Max response time: 128704.31 ms
  • Average response time: 1963.72 ms
  • Median response time: 210.00 ms
  • Requests per second: 2.70

Click here to view full results: https://github.com/cmu-delphi/delphi-epidata/actions/runs/4427677525.

@melange396 melange396 merged commit bf62161 into dev Mar 15, 2023
@melange396 melange396 deleted the perftests_with_as_of branch March 15, 2023 15:06
@melange396 melange396 restored the perftests_with_as_of branch March 16, 2023 14:52
@melange396 melange396 deleted the perftests_with_as_of branch March 16, 2023 14:53
@melange396 melange396 restored the perftests_with_as_of branch March 16, 2023 14:57
@melange396 melange396 deleted the perftests_with_as_of branch March 16, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants