Skip to content

Add SQL override to Makefile #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2023
Merged

Add SQL override to Makefile #1076

merged 1 commit into from
Feb 3, 2023

Conversation

rzats
Copy link
Contributor

@rzats rzats commented Feb 3, 2023

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

Adds a configuration option to the Makefile to make it able to build with a different database set as target. Needed for the scaling test rig to make run off of a database other than a locally created one.

@rzats rzats requested a review from krivard February 3, 2023 15:24
krivard
krivard approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 solid & straightforward

@rzats rzats merged commit f949439 into dev Feb 3, 2023
@rzats rzats deleted the rzatserkovnyi/makefile-sql branch February 3, 2023 16:01
@krivard krivard mentioned this pull request Feb 9, 2023
Merged
@rzats rzats restored the rzatserkovnyi/makefile-sql branch February 13, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krivard krivard krivard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rzats @krivard