-
Notifications
You must be signed in to change notification settings - Fork 67
Mark retired indicators inactive on api documentation #1066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to covid-act-now.md and usa-facts.md are good.
Changes to quidel.md need adjustment: only the flu signals are inactive. We can either:
- leave quidel.md alone, since the last issue date May 19, 2020 is already there, or
- move the flu signals to a new quidel-inactive.md page (see safegraph.md and safegraph-inactive.md for an example)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch on the lingering safegraph file!
Fixed a copypasta but otherwise good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github 🤖 i know you're trying to help but it was my commit, so my review still stands
closes #1733
Summary
Marked inactive in this PR: covid_act_now, quidel, usafacts.
Mentioned in #1734 but already marked inactive previously: combo_cases_and_deaths, safegraph_patterns
Tested by running jekyll website locally:
