Skip to content

Mark retired indicators inactive on api documentation #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 17, 2023

Conversation

minhkhul
Copy link
Contributor

@minhkhul minhkhul commented Jan 17, 2023

closes #1733

Summary

Marked inactive in this PR: covid_act_now, quidel, usafacts.
Mentioned in #1734 but already marked inactive previously: combo_cases_and_deaths, safegraph_patterns

Tested by running jekyll website locally:
Screenshot 2023-01-17 at 2 31 54 PM

@minhkhul minhkhul requested a review from krivard January 17, 2023 19:35
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to covid-act-now.md and usa-facts.md are good.

Changes to quidel.md need adjustment: only the flu signals are inactive. We can either:

  • leave quidel.md alone, since the last issue date May 19, 2020 is already there, or
  • move the flu signals to a new quidel-inactive.md page (see safegraph.md and safegraph-inactive.md for an example)

@minhkhul
Copy link
Contributor Author

Modified quidel.md under Data Sources and Signals:
Screenshot 2023-01-17 at 4 46 06 PM

Added quidel-inactive.md under Inactive Signals:
Screenshot 2023-01-17 at 4 47 23 PM

Remove safegraph.md as both Social Distancing Metrics and Weekly patterns are now inactive. All safegraph docs are now under inactive signals in safegraph-active.md

@minhkhul minhkhul requested a review from krivard January 17, 2023 21:50
krivard
krivard previously approved these changes Jan 17, 2023
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on the lingering safegraph file!

Fixed a copypasta but otherwise good to go.

Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github 🤖 i know you're trying to help but it was my commit, so my review still stands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deactivate USAFacts indicator
2 participants