API server code health pass - rename *Pair classes to *Set #1060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzats
force-pushed
the
rzatserkovnyi/code-health-pair-set
branch
from
05c4c4d to
72f9cb8
Compare
melange396
requested changes
Dec 22, 2022
| for pair in source_signals: | ||
| source = data_source_by_id.get(pair.source) | ||
| transformed_sets: List[SourceSignalSet] = [] | ||
| for set in source_signals: |
There was a problem hiding this comment.
similar to comment above; perhaps use ssset here?
There was a problem hiding this comment.
That name feelsss very Pythonic... 🐍
melange396
requested changes
Dec 22, 2022
rzats
force-pushed
the
rzatserkovnyi/code-health-pair-set
branch
from
d11e4ce to
888897d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #998.
Prerequisites:
devbranchdevSummary
Fixes a set of issues in the server code as described here.
*Pairclasses (TimePair,GeoPair,SourceSignalPair) into*Set.WHEREconditional. In this case they are referred to as filters.