Skip to content

[JIT Variant]: Reduce iterator stack on base signals #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Dec 8, 2022

This is a variant of #1026.

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

Create an early exit from the JIT iterator stack for non-derived signals. The advantage of this approach is that it still relies on a single database query, instead of making multiple, like #1026.

@dshemetov dshemetov marked this pull request as draft December 8, 2022 22:44
@dshemetov dshemetov marked this pull request as ready for review February 22, 2023 23:03
@dshemetov dshemetov merged commit f6dfed9 into jit_computations Feb 22, 2023
@dshemetov dshemetov deleted the ds/jit-faster-base-signals branch February 22, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant