Skip to content

Change logging scheme for validation #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2021

Conversation

sgsmob
Copy link
Contributor

@sgsmob sgsmob commented Mar 31, 2021

Description

Update the logging scheme for validation to properly log indicator and validation output.

Changelog

  • Indicator runner actually logs its results
  • ValidationReport.log() now takes an additional parameter specifying the logger to use

@sgsmob sgsmob requested a review from benjaminysmith March 31, 2021 19:32
@krivard
Copy link
Contributor

krivard commented Mar 31, 2021

You have a linter error:

. env/bin/activate; pylint delphi_utils
************* Module delphi_utils.validator.report
delphi_utils/validator/report.py:10:68: W0613: Unused argument 'log_filename' (unused-argument)

-----------------------------------
Your code has been rated at 9.99/10

@sgsmob
Copy link
Contributor Author

sgsmob commented Mar 31, 2021

You have a linter error:

. env/bin/activate; pylint delphi_utils
************* Module delphi_utils.validator.report
delphi_utils/validator/report.py:10:68: W0613: Unused argument 'log_filename' (unused-argument)

-----------------------------------
Your code has been rated at 9.99/10

Done

@krivard krivard merged commit 16d8962 into cmu-delphi:main Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants