Skip to content

Google Symptoms uses metadata to determine how many days of data to fetch #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2021

Conversation

nmdefries
Copy link
Contributor

Description

Instead of pulling a fixed 14 days of data, determine number of days to pull based on metadata min_lag value. Pre-existing functionality (num_export_days can be set in params to an integer or to "all") still works.

Changelog

  • Pull GS-specific min_lag from metadata if num_export_days is not set in params.
  • Remove 14-day num_export_day setting from template and Ansible params files.

Fixes

Makes GS pipeline more robust to BigQuery outages. Minimize data pulled in anticipation of change to daily updates.

@nmdefries nmdefries requested a review from jingjtang March 29, 2021 16:12
@nmdefries nmdefries requested a review from jingjtang March 31, 2021 19:32
Copy link
Contributor

@jingjtang jingjtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@krivard krivard merged commit 3f15ac6 into main Mar 31, 2021
@krivard krivard deleted the gs-metadata-lag branch March 31, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants