Skip to content

Add NAN code support to JHU #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add NAN code support to JHU #839

wants to merge 1 commit into from

Conversation

dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Feb 18, 2021 •
edited
Loading

Description

Work as part #838.

Changelog

  • Allow nan values to pass through in the "val" column
  • Add three missingness columns, default to NA for "sample_size" and "stderr" columns
  • Code Puerto Rico deaths at the county level as a region exception
  • Code the first 6 days as "insufficient data" for the 7 day average signal

Fixes

@dshemetov dshemetov mentioned this pull request Feb 18, 2021
Open
17 tasks
@dshemetov dshemetov force-pushed the nans_jhu branch 4 times, most recently from 7e91694 to d64dc06 Compare April 6, 2021 22:21
@dshemetov dshemetov force-pushed the nans_jhu branch 2 times, most recently from df6e444 to 410049d Compare April 27, 2021 20:19
@dshemetov
NAN codes for JHU:
0f50fd7 
* keep nan values, add missing columns, add missing today, add tests
@dshemetov dshemetov requested review from a team and nmdefries and removed request for a team November 10, 2021 22:26
nmdefries
nmdefries approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@nmdefries nmdefries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dshemetov
Copy link
Contributor Author

JHU doesn't exist anymore.

@dshemetov dshemetov closed this Dec 9, 2023
@dshemetov dshemetov deleted the nans_jhu branch December 9, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmdefries nmdefries nmdefries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dshemetov @nmdefries