-
Notifications
You must be signed in to change notification settings - Fork 16
Finish quidel geo util refactor #665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@chinandrew I got these for linting. No big problems.
Other than these, the logic looks fine. All tests passed |
@krivard informed me that the run-quidel branch already has these changes and just isn't in main yet, so I guess this may not be needed? |
@chinandrew Oh, yes. I have finished the geo util refactor in run-quidel branch. Didn't realize that it is not in the main. Sorry about the duplicate work that you did. The work still left for Quidel is:
|
|
is run-quidel what's currently deployed? |
@chinandrew |
ah, right. in that case I think this PR can be closed and we'll just figure out the run-quidel issue |
Description
For some reason quidel_covidtest was refactored but quidel wasn't finished. Basically just copied the changes from b39d55f
Changelog
Itemize code/test/documentation changes and files added/removed.
Fixes