Add HHS to geomapper util #610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinandrew
requested review from
a team,
benjaminysmith,
sgsmob,
krivard,
melange396 and
eujing
and removed request for
a team,
benjaminysmith,
sgsmob,
krivard and
melange396
sgsmob
approved these changes
Dec 8, 2020
| @@ -102,8 +106,10 @@ def __init__(self): | |||
| """ | |||
| self.crosswalk_filepaths = CROSSWALK_FILEPATHS | |||
| self.crosswalks = { | |||
| "zip": {"fips": None, "hrr": None, "msa": None, "pop": None, "state": None}, | |||
| "fips": {"zip": None, "hrr": None, "msa": None, "pop": None, "state": None}, | |||
| "zip": {"fips": None, "hrr": None, "msa": None, | |||
There was a problem hiding this comment.
Are these always going to have None as the value? Might be more scalable/futureproof to write as a dictionary comprehension:
"zip": {x:None for x in ["fips",...]}
There was a problem hiding this comment.
I think so, unless we end up preloading crosswalks sometime? I'll add your suggestion.
This was referenced Dec 9, 2020
This was referenced Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently based on the #609 branch for simpler reviewing Rebase to main and merge after #609 is merged
Adds the code to do HHS mapping to the geomapper util, assuming the mapping files are already made.
Changelog
Itemize code/test/documentation changes and files added/removed.
hhs_region_number->hhsFixes