-
Notifications
You must be signed in to change notification settings - Fork 16
Get CHC to pass pydocstyle #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
changehc/delphi_changehc/sensor.py
Outdated
visits (denominator), until we have observed some minimum number of | ||
counts, then calculate the sum over that bin. We restrict the | ||
bin size so to avoid inluding long-past values. | ||
Adjust for backfills (retroactively added observations) by using a variable length smoother. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is pydocstyle forcing you to use a plural here? We use backfill to mean the phenomenon of retroactively added observations, rather than referring to the observations themselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it didn't like the fact that the summary had the exact same word as the method. I reordered in a way to make it pass, let me know if it reads ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually i think it's more confusing now since it's the wrong definition, one moment. EDIT: actually maybe its ok?
Ah sorry, this collided with the CHNG-DV signal changes. Would one of you resolve conflicts? |
will do |
conflicts resolved |
Description
Fix docs on chc indicator so pydocstyle passes.
Changelog
Itemize code/test/documentation changes and files added/removed.
Fixes