-
Notifications
You must be signed in to change notification settings - Fork 16
Sensorization #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rumackaaron
wants to merge
20
commits into
dv-package
Choose a base branch
from
sensorization
base: dv-package
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sensorization #568
Changes from 16 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
72995f7
Initial sensorization commit
rumackaaron e95df8b
Column names from config
rumackaaron 422f61f
Faster code, fix global regression fit
rumackaaron 24435c6
Option to fit without intercept
rumackaaron 5f0d9e4
Sensorize tests
rumackaaron df73cfc
Fix linting
rumackaaron 96066f9
Intercept fit method based on params
rumackaaron ad8d81c
Config for static sensorization
rumackaaron 50afd0e
Column name bug
rumackaaron 0a12976
Static sensorization
rumackaaron 7997fa8
Remove debug statements
rumackaaron babd1e8
Revert column names to old style
rumackaaron c2e3b6f
Get geo values from different df
rumackaaron e3a8886
Test static sensorization
rumackaaron d353e78
Merge branch 'dv-package' into sensorization
rumackaaron a97d344
Update geo_maps merge
rumackaaron 02a9361
Use se variable for Jeffreys
rumackaaron 2b2352b
Update delphi utils
rumackaaron f831b0a
Refactor to use geomapper
rumackaaron e899740
Write sensorization coefs to csv
rumackaaron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what are these comments for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point, HSP changed the column names of the files they were sending us. I was testing the code on a recent drop (with lowercase column names). The code originally had the uppercase names, so I changed them back to pass the tests and to merge the PR.