Fix nchs missing value #535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krivard
requested review from
a team,
dshemetov and
eujing
and removed request for
a team and
dshemetov
eujing
reviewed
Nov 17, 2020
Comment on lines
-75
to
-76
| df = df.groupby( | ||
| ["state", "timestamp"]).sum().reindex(index_df).reset_index() |
There was a problem hiding this comment.
It looks like this reindex step was used to fill in missing values by state and time and removing it makes sense given the discussion.
I am not super familiar with the actual NCHS data, but were there cases of duplicated (state, timestamp) where the sum aggregation should still be retained?
There was a problem hiding this comment.
Yeah, you are right! Let me fix this. Thanks!
eujing
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bug fix. Do not assign 0 to missing values. The nchs mortality weekly table reports incidence. The existence of a missing value means the data does not meet the privacy threshold.
Changelog
Fixes