Skip to content

Fix nchs timestamp #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 16, 2020
Merged

Fix nchs timestamp #529

merged 3 commits into from
Nov 16, 2020

Conversation

jingjtang
Copy link
Contributor

Description

bug fix,the start week used by NCHS is week-ending date not week starting date. So the previous one week shift is incorrect.

Changelog

  • Remove one week shift in export.py
  • Update export related unit tests in tests/test_export.py
  • Update DETAILS.md with epiweeks related definition and explanation.

Fixes

@krivard krivard requested review from a team and krivard and removed request for a team November 16, 2020 18:02
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@krivard krivard merged commit 1328595 into main Nov 16, 2020
@krivard krivard deleted the fix-nchs-timestamp branch November 16, 2020 18:29
@jingjtang jingjtang mentioned this pull request Nov 16, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants