Skip to content

Fix issues causing google_health tests to fail #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 16, 2020

Conversation

sgsmob
Copy link
Contributor

@sgsmob sgsmob commented Nov 16, 2020

Description

google_health's tests were failing on a clean install. This PR hopefully fixes them to work.

Changelog

  • Only run archiving if we are not in test mode. From what I can tell, the archiving deletes files in the receiving folder and thus doesn't let us compare them. This is acceptable to do because:
    • Archive behavior was not being tested at all
    • Archiving will be called from its own module rather than an indicator so it will be deleted from this indicator anyway soon.
  • Evaluates the existence of wip_signal properly. Previous behavior interpreted any string value for the wip_signal param as not having a WIP signal; new behavior mimics the live behavior more closely and interprets non-null strings to count as having a WIP signal.

@sgsmob sgsmob requested review from a team and krivard and removed request for a team November 16, 2020 16:36
@krivard
Copy link
Contributor

krivard commented Nov 16, 2020

I notice that the following production params files do not include the "test" or "test_data_dir" keys; are those fixes in-scope for this PR? Otherwise tests will succeed in CI but the job will fail in staging/prod.

  • ansible/templates/google_health-params-prod.json.j2
  • ansible/templates/google_health-params-test.json.j2

@sgsmob
Copy link
Contributor Author

sgsmob commented Nov 16, 2020

I notice that the following production params files do not include the "test" or "test_data_dir" keys; are those fixes in-scope for this PR? Otherwise tests will succeed in CI but the job will fail in staging/prod.

  • ansible/templates/google_health-params-prod.json.j2
  • ansible/templates/google_health-params-test.json.j2

Added. Let me know if I didn't do that correctly.

Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glorious, thanks!

@krivard krivard merged commit abc9cc8 into cmu-delphi:main Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants