-
Notifications
You must be signed in to change notification settings - Fork 16
Add new Jenkins deployment workflow #522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@chinandrew @krivard We should convene to make sure that we have all the indicators in main before we merge this. I'll need to make a couple of changes as well as I have a test directory configured in a few places as a fail safe. |
Which indicators are outstanding? DV, quidel [covidtest], fb-survey (in R), and maybe one other? |
@chinandrew I think initially we might only need to make sure that we account for what is running in production, so that would be:
Nothing else is scheduled in Automation yet so wouldn't be much of a problem if initially we unpacked the code into the runtime dir. For the initial merge, I think something like this makes sense:
We can give it some time to settle in, and then get it over to prod (I want to take a backup of the prod runtime dir before we do that). |
Ok, looks like this now:
|
@krivard I can't accept those changes because I've already made them as further commits outside of the PR convo and they are now 'Outdated'. I think I broke the PR workflow a little bit. At any rate, I think we can merge this.
When we merge to main this will build+package and then deploy to staging. This is mostly inconsequential at the moment, but will be good to see in action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, apologies for the weird changes confusion
Description
This PR adds new Jenkins functionality to simplify indicator deploys for the new repo development workflow.
It will work like this:
A merge to main:
and then creates a package (at the moment a tar.gz).
A merge to prod:
Changelog
Itemize code/test/documentation changes and files added/removed.