Skip to content

Pass dict params to archiver #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 12, 2020
Merged

Pass dict params to archiver #504

merged 2 commits into from
Nov 12, 2020

Conversation

sgsmob
Copy link
Contributor

@sgsmob sgsmob commented Nov 12, 2020

Description

The archive module failed because we were accessing params as object members rather than as keyed values. Changed to be the latter.

Changelog

  • params.foo has been fixed to params["foo"]

Fixes

krivard
krivard suggested changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda wish there was a way to unit test these so we were less dependent on eyeball checks

@sgsmob
Copy link
Contributor Author

sgsmob commented Nov 12, 2020

Kinda wish there was a way to unit test these so we were less dependent on eyeball checks

I can add some sort of integration test here (probably?)

@krivard krivard merged commit 0fa2d5a into cmu-delphi:main Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krivard krivard krivard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Archive differ run-as-module fails with AttributeError
2 participants
@sgsmob @krivard