Aggregate SirCAL messages by source and error #500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krivard
reviewed
Nov 11, 2020
Comment on lines
86
to
87
| def aggregated_message_for_source(x): return "{complaint} - (last update: {last_updated})".format( | ||
| complaint=x.message, last_updated=x.last_updated.strftime("%Y-%m-%d")) |
There was a problem hiding this comment.
While we're not yet including linting of this package in the repo CI, probably best not to introduce new linting errors
There was a problem hiding this comment.
Eugh sorry -- I had pylint enabled in vscode but for some reason was not catching line length.
| "type": "section", | ||
| "text": { | ||
| "type": "mrkdwn", | ||
| "text": "*{source_name}* {message_for_group}:\n{signals}".format(source_name=source.upper(), message_for_group=message, signals=signal_and_geo_types) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aggregate the complaints in sir-complains-a-lot by source and message
Fixes
Example:
