Skip to content

Enable delphi utils on CI #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 12, 2020
Merged

Enable delphi utils on CI #494

merged 2 commits into from
Nov 12, 2020

Conversation

chinandrew
Copy link
Contributor

Description

Enable testing and linting on CI for delphi utils now that it passes.

Changelog

  • Add delphi utils folder to list of directories to run CI on
  • Fix some small linting issues to get it to pass

Fixes

  • n/a

@chinandrew chinandrew requested a review from krivard November 11, 2020 15:56
@chinandrew chinandrew mentioned this pull request Nov 11, 2020
Merged
krivard
krivard approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@krivard
Copy link
Contributor

krivard commented Nov 12, 2020

nertz, conflicts 😭

@chinandrew
Copy link
Contributor Author

nertz, conflicts

resolved

@krivard krivard merged commit 4483021 into main Nov 12, 2020
@krivard krivard deleted the utils-ci branch November 12, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krivard krivard krivard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chinandrew @krivard